[wp-trac] [WordPress Trac] #36335: Next generation: core autoloader proposal

WordPress Trac noreply at wordpress.org
Thu Aug 25 06:24:00 UTC 2016


#36335: Next generation: core autoloader proposal
-----------------------------+------------------
 Reporter:  dnaber-de        |       Owner:
     Type:  feature request  |      Status:  new
 Priority:  normal           |   Milestone:  4.7
Component:  General          |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:
-----------------------------+------------------

Comment (by jorbin):

 Some initial thoughts on the proposal:

 1) Removing the instantiation of things like `$GLOBALS['wp_press_this'] =
 new WP_Press_This(); ` from the original file is a breaking change.

 2) I would like to see a travis's build matrix updated to include a 5.2
 environment with spl disabled. Should likely have been done with the
 original addition of the shim, but

 3) I apply the patch, and now development doesn't work right away. All I
 get is `Autoloader was not found, aborting.`  That can't be committed.

 4) I don't like the additon of the toplevel `vendor` folder.  this should
 go inside wp-includes.

 5) running `composer install` generates warnings.
 {{{
 Warning: Ambiguous class resolution, "ftp" was found in both
 "/srv/www/blonderepublicansexkitten.com/public_html/src/wp-admin/includes
 /class-ftp-sockets.php" and
 "/srv/www/blonderepublicansexkitten.com/public_html/src/wp-admin/includes
 /class-ftp-pure.php", the first will be used.
 Warning: Ambiguous class resolution, "ftp" was found in both
 "/srv/www/blonderepublicansexkitten.com/public_html/src/wp-admin/includes
 /class-ftp-sockets.php" and
 "/srv/www/blonderepublicansexkitten.com/public_html/src/wp-admin/includes
 /class-ftp-pure.php", the first will be used.
 > xrstf\Composer52\Generator::onPostInstallCmd
 Warning: Ambiguous class resolution, "ftp" was found in both
 "/srv/www/blonderepublicansexkitten.com/public_html/src/wp-admin/includes
 /class-ftp-sockets.php" and
 "/srv/www/blonderepublicansexkitten.com/public_html/src/wp-admin/includes
 /class-ftp-pure.php", the first will be used.
 > xrstf\Composer52\Generator::onPostInstallCmd
 }}}

 6) I'm not sure yet how I feel about automatically making so much of wp-
 admin available on everypage load.  In the past, core has forced
 developers to make a cognitive decision to include those pieces on the
 front end if they want to use them. Is that a change that should be made?
 why?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36335#comment:61>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list