[wp-trac] [WordPress Trac] #34737: Add Facebook oEmbed support

[WordPress Trac]

#34737: Add Facebook oEmbed support
-------------------------------------------------+-------------------------
 Reporter:  pento                                |       Owner:  pento
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
Component:  Embeds                               |  Release
 Severity:  normal                               |     Version:
 Keywords:  has-patch needs-refresh 2nd-opinion  |  Resolution:
                                                 |     Focuses:
-------------------------------------------------+-------------------------
Changes (by pento):

 * keywords:  has-patch => has-patch needs-refresh 2nd-opinion


Comment:

 I think we're at a point where we can only decide if this is going in or
 not. The URLs that Facebook originally defined haven't changed, so I think
 we can call it established, or stable.

 I doubt they'd be willing to change the `height` property that they
 return, their JS handles all of that magic.

 The patch needs some updates:
 - the `.php` parts of the regexes need to be changed to `\.php`
 - I'm inclined to start adding unit tests for all our trusted oEmbed
 providers - if their output changes, we should know about it. Building
 those tests (with Facebook as the first provider) may be out of scope of
 this ticket, though.

 I'm +1 on commit, though I'd like to hear arguments either way.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34737#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform