[wp-trac] [WordPress Trac] #37563: On page updates: Bulk actions FTP dismissal issues

[WordPress Trac]

#37563: On page updates: Bulk actions FTP dismissal issues
-----------------------------------------------------+--------------------
 Reporter:  jorbin                                   |       Owner:
     Type:  defect (bug)                             |      Status:  new
 Priority:  normal                                   |   Milestone:  4.6
Component:  Plugins                                  |     Version:  trunk
 Severity:  normal                                   |  Resolution:
 Keywords:  has-screenshots has-patch needs-testing  |     Focuses:
-----------------------------------------------------+--------------------
Changes (by afercia):

 * keywords:   => has-screenshots has-patch needs-testing
 * version:   => trunk


Comment:

 [attachment:37563.diff] is a possible approach to cover the cases
 illustrated in the screenshots above:
 - stores in the element's jQuery `.data()` also the original `aria-label`
 attribute for later re-use on`plugin-install` and `plugin-install-network`
 - adds a check for `originaltext` that can be undefined, for example when
 canceling the FTP credentials during a bulk update, and in this case
 directly gets the HTML instead of trying to get the HTML stored in `.data(
 'originaltext' )`

 Definitely needs testing and review, not sure all the edge cases are
 covered.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37563#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform