[wp-trac] [WordPress Trac] #31625: Function register_uninstall_hook doesn't have a method to remove the outdated data

[WordPress Trac]

#31625: Function register_uninstall_hook doesn't have a method to remove the
outdated data
-------------------------------------+--------------------------
 Reporter:  voron_eril               |       Owner:  dd32
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  4.6
Component:  Plugins                  |     Version:  4.1.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  performance
-------------------------------------+--------------------------
Changes (by dd32):

 * owner:   => dd32
 * status:  new => accepted
 * milestone:  Future Release => 4.6


Comment:

 Other than not needing to check `$update` (`update_option()` will check if
 the value has changed) [attachment:31625.diff] seems good to me.
 You don't need to create a new patch for that though, can strip that out
 during commit easily enough (feel free to upload a new one if you'd like)

 > I incremented the current db version to an arbitrary 36999 as I wasn't
 sure how it would be calculated.
 We set it to the SVN Commit number of the commit we're making when the
 patch is committed, so an arbitrary number is good :) although I usually
 just use +1 (and then +1 again for the next test iteration.. etc)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31625#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform