[wp-trac] [WordPress Trac] #35433: Walker_Comment::comment calls comment_text which forces the comment to be re-queried rather than use $comments variable cache

WordPress Trac noreply at wordpress.org
Wed Apr 20 21:57:06 UTC 2016


#35433: Walker_Comment::comment calls comment_text which forces the comment to be
re-queried rather than use $comments variable cache
-------------------------------------+-----------------------------
 Reporter:  pcfreak30                |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  Comments                 |     Version:  3.7
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+-----------------------------
Changes (by rachelbaker):

 * keywords:   => has-patch needs-testing
 * milestone:  Awaiting Review => Future Release


Comment:

 In [attachment:35433.diff] instead of passing the comment_id, requiring
 the WP_Comment object to be re-fetched, I am passing in the WP_Comment
 object, which should prevent the additional query.  @pcfreak30 would you
 be able to test the patch here?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35433#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list