[wp-trac] [WordPress Trac] #12922: Setting featured image does not require the post to be saved

WordPress Trac noreply at wordpress.org
Mon Apr 18 12:42:26 UTC 2016


#12922: Setting featured image does not require the post to be saved
-----------------------------+------------------------------
 Reporter:  rooodini         |       Owner:
     Type:  defect (bug)     |      Status:  reopened
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Post Thumbnails  |     Version:  3.0
 Severity:  normal           |  Resolution:
 Keywords:  needs-patch      |     Focuses:
-----------------------------+------------------------------
Changes (by flixos90):

 * keywords:  ux-feedback => needs-patch


Comment:

 We had some further discussions (at the Contributor Day in Nuremberg) and
 came to the conclusion that we can probably fix this without affecting too
 many users (contrary to my previous comment). Most people aren't aware
 that this bug even exists, and they assume that managing the featured
 image works in the way that this ticket is hinting it should.

 About the previous concerns whether this is expected behavior or not:
 While generally media-related changes are saved immediately with AJAX,
 this shouldn't be the case in the context of posts. The featured image
 does not change the attachment itself, but the post that it is attached to
 (similar like inserting media into the post content). Therefore it should
 only do something on hitting the "Update" button.

 To fix the ticket, we should move away from managing the featured image
 through AJAX and instead use a hidden input field to store the image ID
 (or 0 for no featured image or to remove the existing featured image). The
 POST data this would send could then be handled in `edit_post()` (in a
 similar fashion to the current AJAX implementation).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/12922#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list