[wp-trac] [WordPress Trac] #36528: Only run imagemin task inside precommit task if images are added/modified

[WordPress Trac]

#36528: Only run imagemin task inside precommit task if images are added/modified
------------------------------+------------------
 Reporter:  iseulde           |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  4.6
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+------------------
Changes (by jorbin):

 * keywords:  has-patch => has-patch commit


Comment:

 postcss is just the framework.  In and of itself, it does nothing. Not
 sure how that relates to this conversation. Unless you are referring to
 auto-prefixer which we only really need to worry about every six weeks or
 so based on browser releases.

 I think we are fine relying on grunt release. As the person most likely to
 commit an update to `grunt-contrib-imagemin`, I am also fine running it
 manually then. Images aren't added often.  If someone running trunk is
 using an image that is a few KB bigger, well I think they are going to be
 ok.

 Patch refreshed as it no longer applied cleanly.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36528#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform