[wp-trac] [WordPress Trac] #36392: wp_add_inline_script() breaks script dependency order when using script loader (no SCRIPT_DEBUG)

WordPress Trac noreply at wordpress.org
Sat Apr 9 10:30:57 UTC 2016


#36392: wp_add_inline_script() breaks script dependency order when using script
loader (no SCRIPT_DEBUG)
--------------------------------------+-------------------------
 Reporter:  westonruter               |       Owner:  swissspidy
     Type:  defect (bug)              |      Status:  assigned
 Priority:  high                      |   Milestone:  4.5
Component:  Script Loader             |     Version:  trunk
 Severity:  major                     |  Resolution:
 Keywords:  has-unit-tests has-patch  |     Focuses:
--------------------------------------+-------------------------
Changes (by swissspidy):

 * keywords:  has-unit-tests needs-patch => has-unit-tests has-patch


Comment:

 In [attachment:36392.diff] I iterated on the latest patch to fix the unit
 tests. Afterwards, I got rid of the extra `disable_concat ` property and
 the tests still ran properly.

 Feedback appreciated.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36392#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list