[wp-trac] [WordPress Trac] #34071: Incorrect site URL in email templates

[WordPress Trac]

#34071: Incorrect site URL in email templates
--------------------------+------------------
 Reporter:  ramay         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.4
Component:  Users         |     Version:  4.3
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+------------------
Changes (by SergeyBiryukov):

 * keywords:  reporter-feedback => needs-patch
 * version:  4.3.1 => 4.3
 * component:  Mail => Users
 * milestone:  Awaiting Review => 4.4


Comment:

 So, there are 4 instances of that template:

 * [source:tags/4.3.1/src/wp-admin/includes/ms.php#L266
 update_option_new_admin_email()]
 * [source:tags/4.3.1/src/wp-admin/includes/ms.php#L347
 send_confirmation_on_profile_email()]
 * [source:tags/4.3.1/src/wp-includes/user.php#L2201 wp_update_user(), 1]
 * [source:tags/4.3.1/src/wp-includes/user.php#L2256 wp_update_user(), 2]

 The first two use `network_home_url()` and appear to be unaffected.

 The second two use `get_option( 'siteurl' )` and should probably use
 `home_url()` instead.

 Introduced in [32820].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34071#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform