[wp-trac] [WordPress Trac] #33305: Plugin details modal: initial focus and constraining tabbing

[WordPress Trac]

#33305: Plugin details modal: initial focus and constraining tabbing
--------------------------+--------------------------------------------
 Reporter:  afercia       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Plugins       |     Version:  4.2
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  ui, accessibility, javascript
--------------------------+--------------------------------------------
Changes (by afercia):

 * keywords:  reporter-feedback =>


Comment:

 :) Thanks @mehulkaklotar that's a good start. Was thinking to implement
 also some features that are used in (most) of the modal dialogs in the
 admin, and some general best practices, for example:
 - to avoid that long pile of selectors maybe we could use a specific CSS
 class on all the links which open the Plugin details dialog (see for
 example [32645])
 - all those links should also have a `data-title` attribute to hold the
 Plugin name, for use by JavaScript in the dialog
 - get and store a reference of the control which opened the dialog
 - set a proper ARIA role and attributes on the modal dialog
 - constrain the navigation with the tab key within the dialog
 - close the modal when pressing Escape or clicking on the overlay
 - the Close button should be... a button
 - when closing the dialog, set focus back to the control that had focus
 - special case: the Network Admin Themes screen, I think we can't do much
 here other than moving the initial focus on the Close button

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33305#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform