[wp-trac] [WordPress Trac] #31237: improve get_the_archive_title() with new filter

WordPress Trac noreply at wordpress.org
Mon Sep 21 10:27:48 UTC 2015


#31237: improve get_the_archive_title() with new filter
-------------------------+------------------------------
 Reporter:  ramiy        |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Themes       |     Version:  4.1
 Severity:  normal       |  Resolution:
 Keywords:               |     Focuses:  template
-------------------------+------------------------------

Comment (by ramiy):

 Replying to [comment:5 BinaryMoon]:


 > I'd disagree that introducing more code is simpler. I think a span is a
 very simple solution that means we can all get the functionality we want.
 It also means that all users will get the functionality added to their
 sites without a theme update.

 The css approach is not semantic and not accessible. With css span you
 don't remove the prefix text you just hide it. The search engine still see
 the text, the blind person still hear the text with his device. I think we
 should totally remove it. We don't need to echo the prefix text if it's
 not being presented.



 > My concern is that I have users who are happy with it as is, and a small
 handful of users who want it changed. So I don't want to remove it for
 everyone as that will mean I am changing their website.

 The new filter don't remove the prefix text for everyone, it only adds the
 ability not to show the prefix to those how chose to use the filter.



 > I also don't want to introduce yet another option in the theme. If a
 span is added then those who really don't want it can use css to hide it.
 Everyone else can continue as is.

 No mater what approach we chose, you don't have to update your theme.
 users can remove the prefix text with css (in style.css) or with the the
 filter (in functions.php).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31237#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list