[wp-trac] [WordPress Trac] #32802: Update Masonry (v3.3.0) & imagesLoaded (v3.1.8) package

WordPress Trac noreply at wordpress.org
Tue Sep 15 23:31:25 UTC 2015


#32802: Update Masonry (v3.3.0) & imagesLoaded (v3.1.8) package
-------------------------------------------------+-------------------------
 Reporter:  Ninos Ego                            |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  External Libraries                   |  Review
 Severity:  normal                               |     Version:  4.3
 Keywords:  needs-testing needs-codex dev-       |  Resolution:
  feedback needs-patch                           |     Focuses:  javascript
-------------------------------------------------+-------------------------
Changes (by jorbin):

 * keywords:  has-patch needs-testing needs-codex dev-feedback => needs-
     testing needs-codex dev-feedback needs-patch


Comment:

 We shouldn't eliminate 'jquery-masonry' since doing so will break any
 attempt to load that handler. The handler should just load no script and
 have 'masonry' as a dependency.

 imagesLoaded should be a dependency of masonry since it was in the old
 file.  Eliminating it would break sites that depend on it being in
 masonry.

 https://github.com/desandro/masonry/compare/v3.1.3...v3.3.2 is the diff
 between versions.

 We should find a few plugins and themes depending on masonry and make sure
 to test those. Anyone have suggestions?

 @kovshevin, I see your name in some of the commits.  Any thoughts here?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32802#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list