[wp-trac] [WordPress Trac] #33599: Customize: Make the Add a Widget button a button

WordPress Trac noreply at wordpress.org
Thu Sep 3 16:15:31 UTC 2015


#33599: Customize: Make the Add a Widget button a button
--------------------------+--------------------------------------------
 Reporter:  afercia       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.4
Component:  Customize     |     Version:  4.3
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  ui, accessibility, javascript
--------------------------+--------------------------------------------

Comment (by afercia):

 There are a few more things to do here. The buttons: "Add a Widget", "Add
 a Menu" and "Add Items" are very, very, similar and should basically have
 the same CSS rules.
 Same for the HTML part, but here there's no need for an `aria-label`
 attribute to better specify the button's purpose. Also, no more need for
 `tabindex`.
 About the JavaScript part, buttons don't need a `keydown` event. We should
 handle the `aria-expanded` attribute and set proper attributes when the UI
 is in "reordering" mode, as done in the Menu Customizer.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33599#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list