[wp-trac] [WordPress Trac] #33311: TB_window spinner should probably disappear when loading is done

WordPress Trac noreply at wordpress.org
Wed Sep 2 06:20:32 UTC 2015


#33311: TB_window spinner should probably disappear when loading is done
-------------------------+-------------------------------------------------
 Reporter:  niklasbr     |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Plugins      |     Version:  4.2.4
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  ui, javascript, administration,
  dev-feedback           |  performance
-------------------------+-------------------------------------------------

Comment (by niklasbr):

 Thanks for your feedback @afercia! I will remove the RTL part of the
 patch. Though I am not sure what specifically you are referring to when
 you say "there are some things to fix" because from my novice point of
 view I used that guide when creating the patch and it seems to me (again,
 a novice) that I followed it as good as I could.

 Upon reading it again the only thing that strikes me as wrong is the file
 name of the patch, it should be ''33311.patch'' and not ''33311-Fix-
 excessive-resource-usage-due-to-animating-GIF-1.patch'', right? Anything
 else I am missing? Probably.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33311#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list