[wp-trac] [WordPress Trac] #34451: Embeds not working for non-WP sites

[WordPress Trac]

#34451: Embeds not working for non-WP sites
----------------------------------------------------+--------------------
 Reporter:  swissspidy                              |       Owner:
     Type:  defect (bug)                            |      Status:  new
 Priority:  normal                                  |   Milestone:  4.4
Component:  Embeds                                  |     Version:  trunk
 Severity:  major                                   |  Resolution:
 Keywords:  has-patch has-unit-tests needs-testing  |     Focuses:
----------------------------------------------------+--------------------

Comment (by swissspidy):

 Seems like the reason for the broken editor preview was that the secret
 wasn't being added to new iframes (since it only does so in `onLoad`.

 [attachment:34451.4.diff] fixes this by not removing that part from
 `wp_filter_oembed_result()` to make the experience for both WP sites and
 non-WP sites the same, without breaking already existing embeds.

 The only concern now would be that `getSecret()` could lead to an infinite
 loop when there's never a secret added to the iframe.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34451#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform