[wp-trac] [WordPress Trac] #34482: wp-db.php incorrect usage of strip_invalid_text() in process_fields()

[WordPress Trac]

#34482: wp-db.php incorrect usage of strip_invalid_text() in process_fields()
-------------------------------+------------------
 Reporter:  fhwebcs            |       Owner:
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  4.4
Component:  Database           |     Version:  4.2
 Severity:  normal             |  Resolution:
 Keywords:  reporter-feedback  |     Focuses:
-------------------------------+------------------
Changes (by TobiasBg):

 * keywords:   => reporter-feedback


Comment:

 Comparing arrays like this is however not a problem (see
 [http://www.php.net/manual/en/language.operators.array.php the PHP docs]).
 From the function's documentation, it's the desired operation. If text has
 been stripped from the `$data` array, the function shall return `false` so
 that the query is rejected.

 Checking for that `WP_Error` does not make sense here, as that would only
 trigger if the invalid text could not be stripped from the text for some
 reason.

 Could you therefore please explain what errors you are seeing and what
 input/query is triggering them?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34482#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform