[wp-trac] [WordPress Trac] #34149: Standardize wp-signup.php to also use search engine visibility text

WordPress Trac noreply at wordpress.org
Wed Oct 28 22:28:23 UTC 2015


#34149: Standardize wp-signup.php to also use search engine visibility text
--------------------------------------+----------------------------------
 Reporter:  DrewAPicture              |       Owner:  ocean90
     Type:  defect (bug)              |      Status:  assigned
 Priority:  normal                    |   Milestone:  4.4
Component:  Upgrade/Install           |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:  template, multisite
--------------------------------------+----------------------------------

Comment (by DrewAPicture):

 @ocean90 OK, let's try [attachment:34149.4.patch]. I removed the extra
 `label` element and kept the `fieldset`. This approach requires style
 changes for all of the default themes (unless we want labels inside a
 fieldset to look just like the fieldset legend which looks like labels
 outside the fieldset.

 While this approach is more work, I think it's the right way to go.

 I also have a PR prepared for Twenty Sixteen.

 Screenshots:

 Twenty Thirteen:
 [[Image(http://cl.ly/image/1A0I022d0R3x/34149.4.twentythirteen.png)]]

 Twenty Fourteen:
 [[Image(http://cl.ly/image/3S1A2h3i3K1P/34149.4.twentyfourteen.png)]]

 Twenty Fifteen:
 [[Image(http://cl.ly/image/1A1D1M1D2O3x/34149.4.twentyfifteen.png)]]

 Twenty Sixteen:
 [[Image(http://cl.ly/image/01420M1c3H2B/34149.4.twentysixteen.png)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34149#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list