[wp-trac] [WordPress Trac] #34421: Not all code removed responsible for comments caching in Recent Comments widget

WordPress Trac noreply at wordpress.org
Sat Oct 24 01:40:36 UTC 2015


#34421: Not all code removed responsible for comments caching in Recent Comments
widget
-------------------------+----------------------
 Reporter:  alexvorn2    |       Owner:
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:
Component:  Taxonomy     |     Version:  trunk
 Severity:  normal       |  Resolution:  invalid
 Keywords:               |     Focuses:
-------------------------+----------------------
Changes (by boonebgorges):

 * status:  new => closed
 * resolution:   => invalid
 * component:  General => Taxonomy
 * milestone:  Awaiting Review =>


Comment:

 Thanks for the ticket.

 The "fragment caching" referred to in [34581] is the caching of fully-
 formed HTML markup. The commit message on [34581] suggests that, after
 some performance improvements to `WP_Comment_Query`, this HTML caching is
 no longer worth the trouble of invalidation.

 The widget still leverages the object cache, when appropriate. The snippet
 of code you've highlighted is responsible for loading the comment post
 items into the cache, so that subsequent calls to `get_permalink()` (via
 `get_comment_link()`) don't require additional database queries. It's
 still relevant.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34421#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list