[wp-trac] [WordPress Trac] #8071: Refrain from querying all the comments on a post when paged

WordPress Trac noreply at wordpress.org
Wed Oct 21 16:43:03 UTC 2015


#8071: Refrain from querying all the comments on a post when paged
------------------------------------+---------------------------
 Reporter:  markjaquith             |       Owner:  boonebgorges
     Type:  task (blessed)          |      Status:  closed
 Priority:  normal                  |   Milestone:  4.4
Component:  Comments                |     Version:  2.7
 Severity:  normal                  |  Resolution:  fixed
 Keywords:  dev-feedback has-patch  |     Focuses:
------------------------------------+---------------------------
Changes (by boonebgorges):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 [35331] stops forcing comment pagination. While this revert is a shame :(
 we did actually manage to accomplish some real improvements. Comments are
 loaded in a much more svelte manner [34310]. And we now only load the
 comments required by the page, instead of loading them all and letting
 `Walker_Comment` do the pagination work; this part of [34561] survived,
 and it addresses the issue that the current ticket was originally opened
 for.

 I've opened #34389 for further discussion of the performance problems that
 arise from setting `page_comments` to 0. I think we can mark the current
 ticket as fixed.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/8071#comment:63>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list