[wp-trac] [WordPress Trac] #19159: When Inactive Widgets list gets long it is hard to clear

[WordPress Trac]

#19159: When Inactive Widgets list gets long it is hard to clear
---------------------------------------+--------------------------------
 Reporter:  westi                      |       Owner:  cdog
     Type:  enhancement                |      Status:  accepted
 Priority:  normal                     |   Milestone:  4.4
Component:  Widgets                    |     Version:  3.3
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:  ui, accessibility
---------------------------------------+--------------------------------
Changes (by cdog):

 * keywords:  has-patch has-screenshots needs-refresh => has-patch has-
     screenshots


Comment:

 attachment:19159.6.diff​ applies against the current revision.

 What I've done:

 * Refreshed the patch.
 * Refactored the code as suggesed by [comment:16 chriscct7] and
 [comment:23 afercia].
 * Added a new spinner as discussed with [comment:20 DrewAPicture] and
 [comment:23 afercia].
 * The button gets disabled when the list is empty to prevent multiple
 calls as pointed by [comment:18 alexvorn2].
 * Moved the description paragraph outside `.widget-holder` (hidden by
 `.no-js` otherwise).
 * Removed unused styles from the previous patch as noted by [comment:23
 afercia] (the CSS rule clearing floats).
 * Updated the patch to work with JavaScript disabled too.

 What I haven't:

 * Updated error handling to provide visual/audio feedback as suggested by
 [comment:23 afercia]. This should be discussed.
 * Checked if `$_POST` variables are set before unsetting them as pointed
 by [comment:16 chriscct7] (`unset` is harmless in this case).
 * Hidden the button when the list is empty as described by [comment:23
 afercia]. To be discussed, this should target the description paragraph
 too.
 * Prevented multiple calls while clearing the list as pointed by
 [comment:18 alexvorn2].

 @DrewAPicture, please let me know if there's anything else that should be
 updated until tomorrow. Thanks everyone for getting involved!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/19159#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform