[wp-trac] [WordPress Trac] #29792: Grunt: Add a precommit task to check for CSS syntax errors

[WordPress Trac]

#29792: Grunt: Add a precommit task to check for CSS syntax errors
------------------------------+-----------------------
 Reporter:  helen             |       Owner:  netweb
     Type:  enhancement       |      Status:  assigned
 Priority:  normal            |   Milestone:  4.4
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  needs-patch       |     Focuses:
------------------------------+-----------------------

Comment (by netweb):

 Replying to [comment:56 helen]:
 > Replying to [comment:45 netweb]:
 > > First up I'll note that I am an "owner" of both repos
 > Who "owns" the repository doesn't erase the fact that it's separate AND
 external. I'm still not very excited about the prospect of having this be
 external, especially while we're still working things out. Having it
 external AND used in core makes it "blessed", when it's not something I'd
 be comfortable calling final for some time yet.

 Right, I see your point, see below, maybe in the future we can revisit
 this and bless it if deserved ;)

 > > Currently the only way to define Stylelint rules are in said separate
 repository, there are future plans to add support for a `.stylelintrc`
 file, similar to `.jshint` and the like though this has yet to be
 implemented.

 Over the weekend Stylelint `2.0.0` was released with full support for
 `.stylelintrc`, patch
 [https://core.trac.wordpress.org/attachment/ticket/29792/29792.3.diff
 29792.3.diff] uses this new configuration file rather than the previous
 "external repo".

 > That's too bad. I would rather punt on this, then.
 I'm updating the CSS patch based on the rules defined in
 [https://core.trac.wordpress.org/attachment/ticket/29792/29792.3.diff
 29792.3.diff] and we can go from there on punting decisions

 > By the way, you don't need to keep citing the WP CSS Coding Standards as
 a biblical source - it is a living/evolving document that has very little
 to do with our long-existing mess of CSS, and I wrote them in the first
 place. :)
 I linked to these because I needed to cite "something" for any decisions I
 had made in regard to the rules I'd chosen was the only reason :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29792#comment:58>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform