[wp-trac] [WordPress Trac] #34204: Add fallbacks for WP oEmbed JavaScript & CSS

WordPress Trac noreply at wordpress.org
Sat Oct 17 04:27:48 UTC 2015


#34204: Add fallbacks for WP oEmbed JavaScript & CSS
---------------------------+-------------------------
 Reporter:  peterwilsoncc  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.4
Component:  Embeds         |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  javascript
---------------------------+-------------------------

Comment (by peterwilsoncc):

 Refresh following [35235] and the following changes in
 [attachment:34204.5.diff].

 * `featuredBrowser` => `supportedBrowser`
 * enqueue scripts hook renamed `enqueue_embed_scripts` to match new
 convention
 * Moved the `print_emoji_styles` hook to `print_embed_styles`
 * `print_emoji_detection_script` kept on `embed_head` to follow convention
 from `wp_head`
 * in both twentyfifteen and -sixteen the `(no-)js` classes are on the HTML
 element so I have left it there. I can't see any other instances of use on
 the front end.

 Note: there was a bug created following #34272 so the
 [attachment:34272.2.diff:ticket:34272] will need to be applied/committed
 for this patch to work.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34204#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list