[wp-trac] [WordPress Trac] #34204: Add fallbacks for WP oEmbed JavaScript & CSS

WordPress Trac noreply at wordpress.org
Fri Oct 16 05:43:42 UTC 2015


#34204: Add fallbacks for WP oEmbed JavaScript & CSS
---------------------------+-------------------------
 Reporter:  peterwilsoncc  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.4
Component:  Embeds         |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  javascript
---------------------------+-------------------------

Comment (by swissspidy):

 Ah, I didn't see you were already replacing `no-js` with `js`. I think
 that should stay, adding the sharing icon when the class is `js`. So
 that's fine.

 What I'd change now:

 * Move the `no-js` / `js` class to the body class, like in the rest of
 core
 * Rename `featuredBrowser` to something like `supportedBrowser`.
 * Hook `print_emoji_detection_script`, `print_oembed_embed_scripts` et al
 to the new `wp_oembed_enqueue_scripts` hook.

 I can do the refresh once these tickets get in.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34204#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list