[wp-trac] [WordPress Trac] #34255: Edit permalink accessibility improvements

[WordPress Trac]

#34255: Edit permalink accessibility improvements
--------------------------+------------------------------------------------
 Reporter:  afercia       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.4
Component:  Permalinks    |     Version:  4.3
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  ui, accessibility, administration
--------------------------+------------------------------------------------
Changes (by afercia):

 * keywords:   => has-patch


Comment:

 First pass:
 - the "Cancel" link should be a button, see #26504
 - add an `aria-label` attribute to the Edit button to better describe its
 purpose
 - add `wp.a11y.speak` message to confirm saving
 - JS: buttons with a `type="button"` attribute don't have a default action
 to prevent
 - JS: the keypress event doesn't work with the Escape key in all browsers
 (using Chrome, pressing Escape when the input field is focused doesn't
 close it)
 - JS: use jQuery normalized `which` for key codes
 - JS: use `e.preventDefault();` when pressing Enter on the input field
 instead of `return false`
 - JS: no need for `return false` when pressing Escape
 - JS: delegate a click event on `#titlediv` instead of `#edit-slug-box` to
 prevent screen readers announcing "clickable Permalink"

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34255#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform