[wp-trac] [WordPress Trac] #18590: Swap out "return false" JS calls for preventDefault

WordPress Trac noreply at wordpress.org
Thu Oct 8 21:56:02 UTC 2015


#18590: Swap out "return false" JS calls for preventDefault
-------------------------------------------------+-------------------------
 Reporter:  Viper007Bond                         |       Owner:
     Type:  enhancement                          |  adamsilverstein
 Priority:  normal                               |      Status:  reviewing
Component:  Administration                       |   Milestone:  Awaiting
 Severity:  normal                               |  Review
 Keywords:  needs-testing has-patch dev-         |     Version:  3.3
  feedback                                       |  Resolution:
                                                 |     Focuses:  javascript
-------------------------------------------------+-------------------------

Comment (by azaozz):

 Replying to [comment:14 adamsilverstein]:

 18590.diff looks good. The only place where it may be better to keep
 `return false` is in wp-includes/js/comment-reply.js as we already use
 "DOM level 0" stuff like `cancel.onclick = function()...`, etc.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/18590#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list