[wp-trac] [WordPress Trac] #34037: Setting blog upload limit to 0 doesn't work

WordPress Trac noreply at wordpress.org
Wed Oct 7 06:14:16 UTC 2015


#34037: Setting blog upload limit to 0 doesn't work
--------------------------+----------------------------------------
 Reporter:  boonebgorges  |       Owner:  jeremyfelt
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.4
Component:  Media         |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  administration, multisite
--------------------------+----------------------------------------

Comment (by jeremyfelt):

 In [changeset:"34899"]:
 {{{
 #!CommitTicketReference repository="" revision="34899"
 Tests: Improve tests for `is_upload_space_available()`.

 * Move all tests to a new 'multisite/isUploadSpaceAvailable.php'
 * Store original `blog_upload_space` values before the class is loaded.
 * Restore these values after each test tear down to avoid pollution.

 Commit to testing `is_upload_space_available()` itself by always filtering
 the amount of space used through `pre_get_space_used`. This allows us to
 sanely test without worrying about the local environment. In the future,
 we may be able to remove some of these tests as
 `get_upload_space_available()` tests are built out and reliable.

 See #34037.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34037#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list