[wp-trac] [WordPress Trac] #15384: wp-login.php refactor

[WordPress Trac]

#15384: wp-login.php refactor
-------------------------------------------------+-------------------------
 Reporter:  nacin                                |       Owner:
     Type:  enhancement                          |  valendesigns
 Priority:  normal                               |      Status:  assigned
Component:  Login and Registration               |   Milestone:  Awaiting
 Severity:  normal                               |  Review
 Keywords:  dev-feedback needs-patch needs-      |     Version:
  unit-tests                                     |  Resolution:
                                                 |     Focuses:
-------------------------------------------------+-------------------------
Changes (by valendesigns):

 * keywords:  has-patch dev-feedback => dev-feedback needs-patch needs-unit-
     tests
 * owner:   => valendesigns
 * status:  reopened => assigned


Comment:

 This ticket has the potential to greatly impact the Two Factor feature
 plugin. I can do a thorough review of  [attachment:15384.patch] in the
 next day or two and discuss my findings here and at the weekly meeting on
 Thursday in `core-passwords`.

 In order to merge 2fa into Core for the 4.5 release, we would have to do
 something along these lines anyhow. So I'm for changing how we access
 these functions and build the `wp-login.php` page. Though making sure we
 are thinking about backwards compatibility, potential plugin breakage, and
 all possible use cases is extremely important for such a critical system.

 @jfarthing84 Great effort so far, though because this patch is unfinished
 and doesn't work with interim login in the Customizer, I feel it should
 still be set to `needs-patch`.

 Does anyone have objections to setting the milestone to 4.4?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/15384#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform