[wp-trac] [WordPress Trac] #34172: wp_list_pluck missing checks

WordPress Trac noreply at wordpress.org
Tue Oct 6 18:46:05 UTC 2015


#34172: wp_list_pluck missing checks
--------------------------+------------------------------
 Reporter:  wpsmith       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  performance
--------------------------+------------------------------
Changes (by wpsmith):

 * keywords:  close =>


Comment:

 Replying to [comment:1 boonebgorges]:
 > I think this might be a case where `isset()` checks will paper over
 developer error. The PHP notices are a sign to the developer that
 something has gone wrong. Silently skipping items in the array seems like
 a bad idea to me.

 I do not believe that (covering developer error) to be the case. The
 example I am giving is done on purpose. I have a related ticket that I am
 currently writing up. This ticket and patch is more as a result of #28900.

 Please review the [https://gist.github.com/wpsmith/91b8cab4d258133b32d3
 sample gist] again.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34172#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list