[wp-trac] [WordPress Trac] #31130: WP_INSTALLING causes leakage between unit tests

[WordPress Trac]

#31130: WP_INSTALLING causes leakage between unit tests
------------------------------------+---------------------------
 Reporter:  boonebgorges            |       Owner:  boonebgorges
     Type:  defect (bug)            |      Status:  assigned
 Priority:  normal                  |   Milestone:  4.4
Component:  Build/Test Tools        |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+---------------------------

Comment (by boonebgorges):

 Thanks, jeremyfelt. Let's see what breaks after [34828].

 I'm thinking that a make/core post is probably appropriate for this
 change. I just spent some time looking through the plugin repo to see what
 people were doing with `WP_INSTALLING`. Most of them fall into one of a
 few camps: (a) those that check the constant to make sure we're not
 literally installing WordPress, (b) those that define the constant because
 they're doing things like cloning a site, (c) those that define the
 constant because they're bootstrapping WordPress again (?), and (d)
 caching plugins that point `wp_cache_get()` to `delete()` rather than
 `get()` when `WP_INSTALLING`. From what I can see, those in camp (a) will
 be unaffected in any meaningful way, and those who are doing (c) have
 already voided their warranty. (b) and (d) are a little less clear to me.
 For the vast majority of cases (ie, during a normal installation/upgrade),
 they won't be affected, since `WP_INSTALLING` is defined as part of the
 bootstrap. The question is whether not having the constant available
 during site creation will do anything funny with cache implementations. I
 don't *think* it will, since the cache for a newly created site will be
 empty anyway, but there could turn out to be cache invalidation problems
 for global cache groups. Anyone have thoughts about this?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31130#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform