[wp-trac] [WordPress Trac] #34140: WP_Customize_Setting::update( $value ) bad return value

WordPress Trac noreply at wordpress.org
Sun Oct 4 19:16:52 UTC 2015


#34140: WP_Customize_Setting::update( $value ) bad return value
-------------------------------+------------------------------
 Reporter:  wpweaver           |       Owner:
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Customize          |     Version:  4.3.1
 Severity:  normal             |  Resolution:
 Keywords:  reporter-feedback  |     Focuses:
-------------------------------+------------------------------

Comment (by wpweaver):

 Replying to [comment:2 westonruter]:

 My apologies - I missed seeing this reply this morning.

 I was ''trying'' to add an action for customize_preview, just as you said.

 However, the approach to use new MyCustom_Setting as the arg to
 add_setting works better. However, as far as I can find, that technique is
 not documented anywhere.

 There has been a lot of discussion about using sub classes for customizer,
 but not much documentation or examples. It is not all the great to have to
 resort to reading code.

 AND, this report is still a valid bug report as any line with "return
 do_action(xxxx)" is incorrect. One should not return a value from a
 function that does not return a value.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34140#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list