[wp-trac] [WordPress Trac] #14356: Better string for onbeforeunload event dialog

WordPress Trac noreply at wordpress.org
Thu Oct 1 21:23:49 UTC 2015


#14356: Better string for onbeforeunload event dialog
-------------------------------------+-------------------------------------
 Reporter:  demetris                 |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  lowest                   |   Milestone:  Future Release
Component:  Editor                   |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  ux-feedback dev-         |     Focuses:  javascript,
  feedback has-patch                 |  administration
-------------------------------------+-------------------------------------
Changes (by adamsilverstein):

 * keywords:  ux-feedback needs-patch => ux-feedback dev-feedback has-patch


Comment:

 In [attachment:14356.diff]:
 * Change `onbeforeunload` string from "The changes you made will be lost
 if you navigate away from this page." to "You have unsaved changes that
 will be lost!"

 The purpose of this string change is to clear up the language and reduce
 redundancy in browsers than in mention navigating away in their dialogs
 already. The improvement is especially notable in Chrome, older IE and to
 a lesser extent safari. In browsers that don't display the string,
 changing it does no harm, where it is displayed this notably improves the
 overall wording of the resulting dialog. Open to any tweaks to the exact
 language anyone can suggest, this does seem better than what we have now.

 Here is how this looks in various browsers. Note that current versions of
 Firefox do not display the string so don't change

 === Before ===

 [[Image(http://cl.ly/image/0f0P3R3n280e/Monosnap_2015-10-01_14-55-56.jpg)]]

 [[Image(http://cl.ly/image/012t3q0v1d0w/Dashboard_2015-10-01_15-05-44.jpg)]]

 [[Image(http://cl.ly/image/3P0n2S3K0a1o/Dashboard_2015-10-01_15-04-45.jpg)]]

 [[Image(http://cl.ly/image/3a0i1s2W1R2b/Monosnap_2015-10-01_15-06-28.jpg)]]

 === After ===

 [[Image(http://cl.ly/image/1K2u21302R18/Monosnap_2015-10-01_15-07-23.jpg)]]

 [[Image(http://cl.ly/image/1B3N0q2M3V0g/Dashboard_2015-10-01_15-08-21.jpg)]]

 [[Image(http://cl.ly/image/0B0d290e1o0v/Monosnap_2015-10-01_15-08-58.jpg)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/14356#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list