[wp-trac] [WordPress Trac] #34738: Customizer preview elements lose or misplace their preview data

[WordPress Trac]

#34738: Customizer preview elements lose or misplace their preview data
------------------------------+--------------------------
 Reporter:  Clorith           |       Owner:  westonruter
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  4.4
Component:  Customize         |     Version:  trunk
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:
------------------------------+--------------------------
Changes (by westonruter):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"35724"]:
 {{{
 #!CommitTicketReference repository="" revision="35724"
 Customize: Ensure that a setting (especially a multidimensional one) can
 still be previewed when the post value to preview is set after `preview()`
 is invoked.

 * Introduce `customize_post_value_set_{$setting_id}` and
 `customize_post_value_set` actions which are done when
 `WP_Customize_Manager::set_post_value()` is called.
 * Clear the `preview_applied` flag for aggregated multidimensional
 settings when a post value is set. This ensures the new value is used
 instead of a previously-cached previewed value.
 * Move `$is_preview` property from subclasses to `WP_Customize_Setting`
 parent class.
 * Deferred preview: Ensure that when `preview()` short-circuits due to not
 being applicable that it will be called again later when the post value is
 set.
 * Populate post value for updated-widget with the (unsanitized) JS-value
 in `WP_Customize_Widgets::call_widget_update()` so that value will be
 properly sanitized when accessed in `WP_Customize_Manager::post_value()`.

 Includes unit tests with assertions to check the reported issues and
 validate the fixes.

 Fixes defect introduced in [35007].
 See #32103.
 Fixes #34738.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34738#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform