[wp-trac] [WordPress Trac] #34716: Using wplink (wp_editor) on front end is triggering a js error due to unsatisfied dependency

WordPress Trac noreply at wordpress.org
Fri Nov 20 17:42:22 UTC 2015


#34716: Using wplink (wp_editor) on front end is triggering a js error due to
unsatisfied dependency
--------------------------+----------------------------------------
 Reporter:  imath         |       Owner:  azaozz
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Editor        |     Version:  4.3
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  accessibility, javascript
--------------------------+----------------------------------------
Changes (by afercia):

 * version:   => 4.3


Comment:

 Looking back at this, wondering why jQuery UI is used in the first place.
 Maybe some historical need for key codes normalization but as today I
 think `event.keyCode` is safe to use?
 See attached patch, getting rid of `$.ui` so there's no need to set
 `jquery-ui-core` as dependency.
 Any thoughts?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34716#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list