[wp-trac] [WordPress Trac] #34737: Add Facebook oEmbed support

[WordPress Trac]

#34737: Add Facebook oEmbed support
-------------------------+-----------------------
 Reporter:  pento        |       Owner:  pento
     Type:  enhancement  |      Status:  assigned
 Priority:  normal       |   Milestone:  4.4
Component:  Embeds       |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  needs-patch  |     Focuses:
-------------------------+-----------------------
Changes (by GaryJ):

 * keywords:  has-patch => needs-patch


Comment:

 I think those regexes need checking. For instance, I don't think:

 {{{
 https?://www\.facebook\.com/.*/video(s/|.php).*
 }}}

 will match the last two of (from FB documentation):

 {{{
 https://www.facebook.com/{page-name}/videos/{video-id}/
 https://www.facebook.com/{username}/videos/{video-id}/
 https://www.facebook.com/video.php?id={video-id}
 https://www.facebook.com/video.php?v={video-id}
 }}}

 ...due to there being an extra `/` before `video`. i.e. I think it should
 be:

 {{{
 https?://www\.facebook\.com/.*video(s/|.php).*
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34737#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform