[wp-trac] [WordPress Trac] #34738: Customizer preview elements lose or misplace their preview data

WordPress Trac noreply at wordpress.org
Thu Nov 19 08:03:05 UTC 2015


#34738: Customizer preview elements lose or misplace their preview data
-------------------------------------------------+-------------------------
 Reporter:  Clorith                              |       Owner:
     Type:  defect (bug)                         |  westonruter
 Priority:  normal                               |      Status:  accepted
Component:  Customize                            |   Milestone:  4.4
 Severity:  normal                               |     Version:  4.3
 Keywords:  has-patch needs-testing needs-unit-  |  Resolution:
  tests dev-feedback                             |     Focuses:
-------------------------------------------------+-------------------------
Changes (by westonruter):

 * keywords:   => has-patch needs-testing needs-unit-tests dev-feedback


Comment:

 In [attachment:34738.0.diff]:

 * Move `$is_previewed` from `WP_Customize_Setting` child classes to
 parent.
 * Introduce `customize_post_value_set` and
 `customize_post_value_set_{$setting_id}` actions. Use to defer calling
 `WP_Customize_Setting::preview()` until it has a value to set, and to
 clear out the previewed-applied flag for a multidimensional-aggregated
 value whenever its post value is updated.
 * Ensure that a multidimensional setting's post value is applied to
 preview if the setting is previewed.
 * Ensure that a widget instance's JS value is set as the post value.

 Needs new unit tests to cover the new scenarios.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34738#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list