[wp-trac] [WordPress Trac] #34561: Abstract some embed template code into functions

WordPress Trac noreply at wordpress.org
Wed Nov 18 20:50:55 UTC 2015


#34561: Abstract some embed template code into functions
-------------------------+---------------------------
 Reporter:  johnbillion  |       Owner:  DrewAPicture
     Type:  enhancement  |      Status:  reviewing
 Priority:  normal       |   Milestone:  4.4
Component:  Embeds       |     Version:  trunk
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+---------------------------

Comment (by DrewAPicture):

 In [changeset:"35689"]:
 {{{
 #!CommitTicketReference repository="" revision="35689"
 Embeds: Introduce `print_embed_comments_button()`,
 `print_embed_sharing_button()`, and `print_embed_sharing_dialog()`, which
 respectively output the comments button, sharing buttons, and sharing
 dialog elements in the embed template.

 This change hooks these new output functions to existing hooks in the
 embed template, allowing for more straightforward display control of these
 elements.

 Leaves the embed header and footer intact pending further modularization
 in a future release.

 Props juliobox, swissspidy, DrewAPicture.
 See #34561.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34561#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list