[wp-trac] [WordPress Trac] #32286: How do I change my profile picture?

WordPress Trac noreply at wordpress.org
Wed Nov 11 19:24:06 UTC 2015


#32286: How do I change my profile picture?
-------------------------------------------------+-------------------------
 Reporter:  iseulde                              |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  4.4
Component:  Users                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-screenshots has-  |     Focuses:
  patch commit                                   |  administration
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * keywords:  good-first-bug has-screenshots has-patch => good-first-bug
     has-screenshots has-patch commit


Comment:

 Replying to [comment:13 obrienlabs]:
 > This is my first time doing a patch submission, a little nervous and I
 sure hope I got everything right!

 Looks good, just two things:
 * No need for the callback function, `apply_filters()` is enough.
 * New filters need to be documented as per the
 [https://make.wordpress.org/core/handbook/best-practices/inline-
 documentation-standards/php/#4-hooks-actions-and-filters documentation
 standards].

 I also think we should always apply the filter, so that plugin authors
 could alter the text displayed for other users too if they want.

 See [attachment:32286.2.patch].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32286#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list