[wp-trac] [WordPress Trac] #34456: Add add_theme_support('title-tag') to all default WordPress themes as wp_title() is deprecated since WordPress 4.4

[WordPress Trac]

#34456: Add add_theme_support('title-tag') to all default WordPress themes as
wp_title() is deprecated since WordPress 4.4
---------------------------------------+-----------------------
 Reporter:  Nikschavan                 |       Owner:  obenland
     Type:  defect (bug)               |      Status:  accepted
 Priority:  normal                     |   Milestone:  4.4
Component:  Bundled Theme              |     Version:  trunk
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:
---------------------------------------+-----------------------
Changes (by obenland):

 * keywords:  has-patch has-screenshots needs-testing => has-patch has-
     screenshots


Comment:

 After giving it a bit more thought, I don't think we should update default
 themes at all. The reason being that we would break back compat for every
 site that has a filter hooked into `wp_title`, which is obviously not a
 good experience.

 I added a patch that would make the notice less obtrusive and also stop
 hijacking the title on sites that have `WP_DEBUG` enabled in production,
 which I think could be a good compromise. If the
 `deprecated_function_trigger_error` filter had the function as a second
 argument we could even disable displaying the notice at all in these
 themes, which in this case might make sense because we know they will
 never get updated.

 Thoughts?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34456#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform