[wp-trac] [WordPress Trac] #34561: Abstract some embed template code into functions

[WordPress Trac]

#34561: Abstract some embed template code into functions
------------------------------------+--------------------
 Reporter:  johnbillion             |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  4.4
Component:  Embeds                  |     Version:  trunk
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+--------------------

Comment (by juliobox):

 I don't think that ''the_embed_footer'' should print the share button,
 since we can ''remove_filter'' on ''print_embed_sharing_dialog'' if i
 don't want this embed to be shared.
 I just tested it and of course it's weird to have the share button with no
 effect on click.

 The attached patch will separate the button and the dialogs by adding a
 new action hook.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34561#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform