[wp-trac] [WordPress Trac] #34312: On Multisite has_site_icon( $child_blog_id ) when checking from the root blog is false even if the child blog has a site icon

[WordPress Trac]

#34312: On Multisite has_site_icon( $child_blog_id ) when checking  from the root
blog is false even if the child blog has a site icon
-------------------------------------------------+-------------------------
 Reporter:  imath                                |       Owner:  jeremyfelt
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  4.4
Component:  Networks and Sites                   |     Version:  4.3
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch dev-feedback has-unit-     |     Focuses:  multisite
  tests                                          |
-------------------------------------------------+-------------------------
Changes (by jeremyfelt):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"35572"]:
 {{{
 #!CommitTicketReference repository="" revision="35572"
 Site Icon: Wrap site icon retrieval with `switch_to_blog()` as needed.

 When the site icon for another site is requested, retrieving its ID via
 `get_blog_option()` is not enough. `switch_to_blog()` is used to set
 proper context when required.

 Adds multsite tests for `has_site_icon()`.

 Props imath.
 Fixes #34312.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34312#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform