[wp-trac] [WordPress Trac] #21389: Retina theme custom headers

WordPress Trac noreply at wordpress.org
Thu Nov 5 22:20:57 UTC 2015


#21389: Retina theme custom headers
-------------------------------------------------+-------------------------
 Reporter:  nacin                                |       Owner:  joemcgill
     Type:  task (blessed)                       |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.4
Component:  Customize                            |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  responsive-images has-patch 2nd-     |     Focuses:
  opinion                                        |
-------------------------------------------------+-------------------------

Comment (by azaozz):

 Yes, we should add an empty alt attribute to the defaults, and yes,
 21389.1.diff is more optimized than 21389.2.diff. It uses the same method
 of adding the srcset and sizes attributes as at the bottom of
 wp_get_attachment_image(). However think it is better to use the data
 returned by get_custom_header() instead of running the whole
 wp_get_attachment_image(). There is also a chance the latter may return
 different values in some edge cases.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21389#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list