[wp-trac] [WordPress Trac] #21389: Retina theme custom headers

[WordPress Trac]

#21389: Retina theme custom headers
-------------------------------------------------+-------------------------
 Reporter:  nacin                                |       Owner:  joemcgill
     Type:  task (blessed)                       |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.4
Component:  Customize                            |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  responsive-images has-patch 2nd-     |     Focuses:
  opinion                                        |
-------------------------------------------------+-------------------------

Comment (by azaozz):

 Replying to [comment:27 Otto42]:
 > The proposal I made 3 years ago was along the same lines...

 Right, sorry, should have linked to [#comment:16 comment 16] in my
 previous comment.

 Replying to [comment:28 joemcgill]:

 We get pretty much everything we need from `get_custom_header()`. Not sure
 if we have to go back and run most of the attachment image functions again
 (it's slow).

 How about we get the srcset and sizes attributes right in
 `get_header_image_tag()`, see
 [https://core.trac.wordpress.org/attachment/ticket/21389/21389.1.diff
 21389.1.diff]. There is some code duplication but is faster and nearly
 identical to the code most themes use now.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21389#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform