[wp-trac] [WordPress Trac] #28410: Walking too many nested comments is inefficient and can break sites

[WordPress Trac]

#28410: Walking too many nested comments is inefficient and can break sites
--------------------------+------------------------------
 Reporter:  dllh          |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Comments      |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  performance
--------------------------+------------------------------

Comment (by stevenkword):

 In this case, the delay is being caused by the walker.  The query itself
 is only taking about 300ms in my vagrant.

 Steps to reproduce:
 1. Import [attachment:export-10kcomments-nested.xml.gz] using the importer
 2. Comment out `$output = $walker->paged_walk( $_comments,
 $r['max_depth'], $r['page'], $r['per_page'], $r );` in the function
 `wp_list_comments()` found in `/wp-includes/comment-template.php`
 3. The page should load in in under a second and the `$_comments` variable
 is set.

 We need to take a better look at the walker methods to resolve the
 reported issue.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28410#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform