[wp-trac] [WordPress Trac] #31985: WP_Network class

[WordPress Trac]

#31985: WP_Network class
--------------------------------+------------------------
 Reporter:  johnjamesjacoby     |       Owner:
     Type:  enhancement         |      Status:  new
 Priority:  normal              |   Milestone:  4.3
Component:  Networks and Sites  |     Version:  3.0
 Severity:  normal              |  Resolution:
 Keywords:  dev-feedback        |     Focuses:  multisite
--------------------------------+------------------------

Comment (by johnjamesjacoby):

 Replying to [comment:5 jeremyfelt]:
 > [https://core.trac.wordpress.org/attachment/ticket/31985/31985.2.diff
 31985.2.diff] cuts down on @johnjamesjacoby's original patch to only
 satisfy the parts setup in `ms-settings.php` and to provide a base object.
 We can decide which parts should be attached to this and which belong in a
 `WP_Network_Query` or elsewhere.
 >
 > All current multisite test are passing. :)

 2.diff looks fine, but the original patch is farther along than this. Was
 my patch causing tests to fail for you?

 I understand the unwinding process, so I can appreciate wanting to see the
 meaty middle and present it for others to digest. I think, though, that
 the original patch (despite missing the inevitable `WP_Network_Query`
 class) makes for a better foundation to iterate from since it already
 brings parity to the single-site `wp-settings.php` file, and isolates many
 of the existing multisite gotchas.

 What's missing between the two diffs represents a few hours of drilling
 down deep into multisite spaghetti and consolidating it into 1 convenient
 location. I think, then, it will be much easier to scrutinize rather than
 going through the cherry-picking process again.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31985#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform