[wp-trac] [WordPress Trac] #29513: Move heavy lifting of wp_mail() to child class of PHPMailer

WordPress Trac noreply at wordpress.org
Sun May 10 22:57:56 UTC 2015


#29513: Move heavy lifting of wp_mail() to child class of PHPMailer
-----------------------------------+-----------------------------
 Reporter:  stephenharris          |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  Future Release
Component:  Mail                   |     Version:  4.0
 Severity:  normal                 |  Resolution:
 Keywords:  2nd-opinion has-patch  |     Focuses:
-----------------------------------+-----------------------------
Changes (by stephenharris):

 * keywords:  2nd-opinion needs-refresh => 2nd-opinion has-patch


Comment:

 Latest patch passes all unit tests (with 47 skipped). All mail component
 tests pass.

 @jorbin The patch still uses the `global $phpmailer`. I personally think
 its a good opportunity to get rid of a global but happy either way. I'll
 dig a little re. why originally a new instance wasn't created for each
 e-mail, but I suspect it might be concerns relating to performance.
 Perhaps constructing a PHPMailer instance is expensive(?). I'll do some
 benchmark tests.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29513#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list