[wp-trac] [WordPress Trac] #32300: twemoji.js - validate data before passing to twemoji.parse

WordPress Trac noreply at wordpress.org
Sun May 10 01:44:35 UTC 2015


#32300: twemoji.js - validate data before passing to twemoji.parse
---------------------------+-------------------------
 Reporter:  peterwilsoncc  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.3
Component:  Formatting     |     Version:  4.2
 Severity:  normal         |  Resolution:
 Keywords:                 |     Focuses:  javascript
---------------------------+-------------------------
Changes (by azaozz):

 * milestone:  Awaiting Review => 4.3


Comment:

 Looking at 32300.3.diff: for an HTML element `node.childNodes` is an
 array. It evaluates to `true` even when empty. We don't need to call
 twemoji.parse() in these cases, returning early in 32300.4.diff.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32300#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list