[wp-trac] [WordPress Trac] #32312: Post Comment button disappeared in some themes

[WordPress Trac]

#32312: Post Comment button disappeared in some themes
-----------------------------------+--------------------
 Reporter:  SergeyBiryukov         |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  4.2.3
Component:  Comments               |     Version:  4.2
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+--------------------
Changes (by boonebgorges):

 * keywords:  needs-patch => has-patch 2nd-opinion


Comment:

 > We should make sure that 'submit_button' and 'submit_field' are still in
 the array after it's filtered.

 [attachment:32312.diff] enforces this for *all* default values. This seems
 like a more general solution for this problem. The only backward
 compatibility concern would be `isset()` checks expecting a given array
 key to be missing after filtering the default arguments. I don't see
 anything like that in `comment_form()`, and `$args` is never passed to a
 hook that might do a similar trick, but it would be nice to get another
 set of eyes.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32312#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform