[wp-trac] [WordPress Trac] #26600: Search installed themes input has no submit button

WordPress Trac noreply at wordpress.org
Tue Mar 31 06:57:47 UTC 2015

#26600: Search installed themes input has no submit button
 Reporter:  grahamarmfield        |       Owner:  SergeyBiryukov
     Type:  defect (bug)          |      Status:  reviewing
 Priority:  normal                |   Milestone:  4.2
Component:  Themes                |     Version:  3.8
 Severity:  normal                |  Resolution:
 Keywords:  has-patch dev-        |     Focuses:  accessibility, javascript
  feedback                        |

Comment (by afercia):

 Replying to [comment:49 helen]:
 Thanks @helen and @evansolomon :) I'd say also for the `themes.Collection`
 the debounce should be set on `doSearch` not on `search`. To my
 understanding, it's the `doSearch` function that needs to be continuously
 called and then it will be called after it stops being called, i.e. when
 users stop typing.

 Also, I'm not sure about all that events bound on the `themes.view.Search`
 events: {
         'input':  'search',
         'keyup':  'search',
         'change': 'search',
         'search': 'search',
         'blur':   'pushState'
 they look a bit too many to me :) wouldn't 'keyup' suffice? added in
 r26291. And can't get what the 'search' event is there, but maybe I'm
 missing something.

Ticket URL: <https://core.trac.wordpress.org/ticket/26600#comment:50>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list