[wp-trac] [WordPress Trac] #26601: Inappropriate content in headings on admin screens

[WordPress Trac]

#26601: Inappropriate content in headings on admin screens
-------------------------------------+-------------------------------------
 Reporter:  grahamarmfield           |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  4.2
Component:  Administration           |     Version:  3.8
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  accessibility,
  dev-feedback                       |  administration
-------------------------------------+-------------------------------------

Comment (by valendesigns):

 Replying to [comment:31 joedolson]:
 > Can you summarize what the purpose of your changes was? The refresh is
 clear and appreciated, but I'm not really sure what you mean by "better
 support for notices" or what the backwards compatibility issue was.

 No problem, sorry for not being more descriptive. The issue with notices I
 discovered was with `#local-storage-notice` interacting with the floating
 `h2`. Basically, the float is not cleared and so the notice gets mangled
 beneath the heading when it displays. The second issue regarding backwards
 compatibility is that any admin pages created that rely on the `h2` to be
 displayed without a `header` loose some of their padding and margin and
 feel tight.

 To solve these issues what I did was clear the float in certain situations
 and add styles that are qualified within a `heading` and by leaving the
 old CSS in place we don't loose styles for plugins and themes that aren't
 updated. Which I would assume will be almost all of them.

 Replying to [comment:32 rianrietveld]:
 > Could you please take a look at the H2 in upload.php for mode=list?
 > The link there is still in the H2.

 I will create a new patch today to address this heading.

 > Maybe we should also include the network screens like /network/site-
 new.php and /network/users.php
 > Or will that better be done in a separate ticket.

 I think it would be best to cover as many of the admin pages as possible
 in this ticket. I can refresh the patch to include more coverage and if
 you see any other pages that need the same treatment we should handle that
 in this ticket, within reason and in the timeframe we have.

 Since we are getting closer to 4.2's release and old styles are still in
 place I don't think it's critical that we convert every single heading.
 They'll still display correctly in the interim, and opening separate
 tickets for the headings we miss seems reasonable to me. So anything that
 we can update this week should be, and beyond that would likely need a new
 ticket as we find them.

 With that said, it's only my opinion and I don't have commit access so one
 of the core devs will still need to chime in and give us some feedback on
 how to handle these missed headings.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26601#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform