[wp-trac] [WordPress Trac] #29881: Better abstraction for WP_Posts_List_Table so it's easier to subclass

WordPress Trac noreply at wordpress.org
Sun Mar 22 16:50:56 UTC 2015


#29881: Better abstraction for WP_Posts_List_Table so it's easier to subclass
-------------------------------------------------+-------------------------
 Reporter:  joehoyle                             |       Owner:  nacin
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
Component:  Administration                       |  Release
 Severity:  normal                               |     Version:  3.1
 Keywords:  has-patch needs-testing needs-       |  Resolution:
  refresh 4.3-early                              |     Focuses:
                                                 |  administration
-------------------------------------------------+-------------------------

Comment (by joehoyle):

 To try get this ticket on track, or closed out as invalid I'd like to get
 some discussion going here if this is a favored patch broadly speaking. It
 appeared initially that it was favored (@nacin chimed in here) - however
 based off the Slack discussion:

 > Drew:
 > Patch is borked and I’m not sure we want to do this right before beta.

 > azaoz:
 > uh, the best abstraction for that is... change to UL LI

 > helen:
 > help was offered, need was expressed, help was not given. punt.
 [in relation to shipping in 4.2)

 Some good advice from Mark, Helen and John at WC London: get the go-head
 and decide on a solution before writing any code. Clearly I made the wrong
 choice by starting with the code here! I really don't want to refresh this
 patch (and take a chunk of time) without there being a consensus that this
 is a good idea.

 There's a couple of comments on this ticket mentioning the patch needs a
 refresh, but based off the initial patch and reception - what this doesn't
 need is a refreshed patch, it needs a decision if this will be adopted for
 r+ or decided against. I think the attached patch sufficiently expresses
 what I wanted to do with this abstraction - we should be talking about
 whether it's a good or bad idea, not requiring a clean merge-able patch
 before we can talk about if the idea is a good or bad one.

 So, I'd like to open up discussion if anyone wants to weigh in here. Once
 we have direction, I'm happy to handle a clean patch if that's decided.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29881#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list